Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:Add the contract address of the event source #82

Merged
merged 3 commits into from
Sep 10, 2022
Merged

feat:Add the contract address of the event source #82

merged 3 commits into from
Sep 10, 2022

Conversation

IanCal
Copy link
Contributor

@IanCal IanCal commented Sep 9, 2022

Summary

The contract_address field in the logs table stores the contract address if one is created in that transaction. I needed to get the contract address that was the source of the event for analysis. I'm not sure of the best naming of the fields, but didn't want the change to break anything downstream so haven't renamed contract_address.

I've also corrected a small typo in a variable name (contracet -> contract).

This is my first rust contribution, so hopefully this was the right way of doing it. Mars looks extremely useful, thanks.

@mergify
Copy link

mergify bot commented Sep 9, 2022

This pull request's title is not fulfill the requirements. @IanCal please update it 🙏.
Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, refactor, ci, build, docs, website, chore

Valid types:

  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci|build: this PR changes build/testing/ci steps
  • docs|website: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@IanCal IanCal changed the title Add the contract address of the event source feat:Add the contract address of the event source Sep 9, 2022
@mergify mergify bot added the pr-feature label Sep 9, 2022
@BohuTANG BohuTANG self-requested a review September 9, 2022 14:06
@BohuTANG
Copy link
Contributor

BohuTANG commented Sep 9, 2022

@IanCal, Thank you for the contribution. I will take a careful review tomorrow.

BohuTANG
BohuTANG approved these changes Sep 10, 2022
View reviewed changes
Copy link
Contributor

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks you for your contribution!

@BohuTANG BohuTANG merged commit 245b14e into deepeth:main Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

Assignees
No one assigned
Labels
pr-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanCal @BohuTANG